Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using global mesh for custom_partitioning. #1112

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Stop using global mesh for custom_partitioning. #1112

merged 2 commits into from
Aug 19, 2024

Conversation

nouiz
Copy link
Collaborator

@nouiz nouiz commented Aug 15, 2024

Description

Please include a brief summary of the changes, relevant motivation and context.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Stop using the global mesh for custom_partitioning. JAX nightly don't need a mesh context anymore. So try to enable that with TE too.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nouiz nouiz requested a review from mingxu1067 August 15, 2024 20:21
@ksivaman
Copy link
Member

Note: #549

@phu0ngng
Copy link
Collaborator

/te-ci jax

mingxu1067
mingxu1067 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@mingxu1067 mingxu1067 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, on the code changes.

@nouiz nouiz mentioned this pull request Aug 16, 2024
Closed
@nouiz
Copy link
Collaborator Author

nouiz commented Aug 16, 2024

/te-ci jax

@nouiz
Copy link
Collaborator Author

nouiz commented Aug 16, 2024

Force pushed the fix as I forgot to sign the commits.

@phu0ngng phu0ngng merged commit ee541e8 into NVIDIA:main Aug 19, 2024
13 of 14 checks passed
BeingGod pushed a commit to BeingGod/TransformerEngine that referenced this pull request Aug 30, 2024
@nouiz @phu0ngng @BeingGod
Stop using global mesh for custom_partitioning. (NVIDIA#1112)
e6d68ce 
Signed-off-by: Frederic Bastien <[email protected]>
Co-authored-by: Phuong Nguyen <[email protected]>
Signed-off-by: beinggod <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingxu1067 mingxu1067 mingxu1067 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nouiz @ksivaman @phu0ngng @mingxu1067